Submitted over 1 year ago

Responsive Landing Page

Blair Chappell•20

@blairhb7

Preview site View code

This is a solution for...News homepage

HTML
CSS
JS

2junior

Design comparison

SolutionDesign

Solution retrospective

The idea behind this project was to make this simple grid landing page, using react, typescript, and tailwind css.

Even though I could have could have made this page using HTML, CSS. I wanted to challenge my React skills and see if I could get the same results using React. I did not spend to much time styling this page other then the given example, but I did map through an array of data for the content on the sidebar and the lower section articles.

Welcoming all feedback thanks!

Community feedback

S MD suleman•3,530
@sulemaan7070Posted over 1 year ago
hey Blair Chappell, great job here are some tips to help you improve the site..

1.I see that you have applied only the desktop-image on both the desktop and the mobile versions.. you will find the image-web3-mobile in the images folder.. you can responsively change the image based on the media-query..

2.You can use picture element here which helps you to switch between the images based on the media-query.. more about picture element here📚

3.The hamburger menu is not aligned with all the mobile sizes.. and it doesn't seem to be working on click...

if you really want to get good at react you can pick challenges with intermediate level of difficulty

The transitions are the best part of your site great job!! happy coding
0
Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

This solution has generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

ESSENTIALS ♻️:

And, This solution has also generated accessibility error reports due to lack of lang and attribute and title tag inside html element

<html> element must have a lang attribute with valid value, so fix it by <html lang="en">

<html> element must have a title tag, so fix it by adding <title>News Homepage</title> inside the html

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord