Design comparison
SolutionDesign
Community feedback
- @Pulkit-s21Posted over 2 years ago
There are a lot of issues in the code.
- Color the background instead of making a box.
- There is no image in the mobile version of your code
- The button is in the middle of the box and not at the end. The components aren't spaced evenly and stick together in desktop version
Marked as helpful1@jish0101Posted over 2 years ago@Pulkit-s21 Thanks, i tried to change it again, see if it looks better?
0@Pulkit-s21Posted over 2 years ago@jish0101 The image is there in the mobile view as well now so kudos on that. Try to set the body min-height to 100vh so that the color is all the way through cause rn it falls shorts and set a max-width for the card in the mobile view like 35em or something like this before it changes to desktop view because it keeps on stretching to the size of the screen and doesnt look that nice. With a fixed max-width it wont span too much and look like a neat card
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord