Design comparison
Solution retrospective
Hi Guys this is my first project in a while. I plan to do a lot more this month, to be consistent. I had a lot of fun doing this challenge, there were a lot of situations where I had to think outside of the box to find solutions. Please you can review it and leave any comments, or feedback. It would be much appreciated. I noticed my background image for the footer is a bit zoomed in if anyone has any feedback on how I can improve that? Thank you
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi, Gabriel! 👋
Congratulations on completing this challenge! 🎉
The background image on the footer looks good in my view. I think it's okay if it is zoomed in on large screen sizes. It is just a decorative image. So, I recommend not worrying too much about it. 🙂
There are other important things that need to be taken care of.
- There is a horizontal scroll bar on the site. I recommend removing it by setting
overflow: hiddento the.heroelement. - For the numbers between each section, I recommend creating those with pseudo-elements instead. It is possible to do it. You can see my solution for your reference.
- The download buttons should be anchor tags with
downloadattribute. - Lastly, I recommend fixing all the issues that have been generated.
I hope this helps! Happy coding!
Marked as helpful0@Gabriel4PFPosted about 2 years ago@vanzasetia Thank you very much for the feedback. I will certainly review your solution using pseudo elements
0 - There is a horizontal scroll bar on the site. I recommend removing it by setting
- @dostonnabotovPosted about 2 years ago
Hi, there! That looks great! However, I found some problems, too
- with regards to your question, try setting a larger
height. But, it looks good to me. - overflow issue on smaller screens with images. Try adding
overflow-x: hiddento your body - don't use backslash
(\)for thesrcattribute in your images. Use forward-slash(/)to specify the directory - not use of
altattribute for the images. It will fail in accessibility - markup is well-structured and easy to read and understand. Well done!
- in terms of CSS, please use a prettier extension or pay close attention to how you are writing. There are some misalignments, spacing, and other issues, which are hard to read and defy the law of CSS.:)
I hope it helps. Good luck!
Marked as helpful0@Gabriel4PFPosted about 2 years ago@dostonnabotov I see yes It was my first time trying touse my own custom properties in CSS. I do hope over time it becomes more clearer read with practice. Thanks for your feedback
0 - with regards to your question, try setting a larger
- @Gabriel4PFPosted about 2 years ago
IF anyone understands my current error coming up on my report. I would appreciate if you commented. I am not sure why I am getting this error
0@vanzasetiaPosted about 2 years ago@Gabriel4PF
Have you clicked the "Learn More" link? There's information about the error and how to solve it. If you still can't solve it then please let me know. 🙂
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord