Design comparison
SolutionDesign
Solution retrospective
Did some mistakes with the HTML! Have used a div inside ul and an article inside the section, and not using an image inside picture tag.
Will rectify it by next time.
Community feedback
- @bramuccciPosted almost 3 years ago
Hi! Congratulations for your solution, the responsive is good and the layout seems correct. Here are some tips:
- You could use semantic better. Use elements like header and footer. I recommend the structure header+main>(section*3)+footer.
- Try naming your classes in a more descriptive way, like "benefits", "testimonials," "gallery" or what you think is better.
- Follow header order; I see a header 1 and 3, but not a 2
- The nav is a little too small.
Overall I think is a great solution! I hope this helps you.
0@hariprasad9899Posted almost 3 years ago@bramuccci Hi !
Thank you so much for your tips.
Going forward, will rectify this things!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord