Design comparison
Community feedback
- @MohammedOnGitPosted 2 months ago
Hello Onyedikachi Miracle Nnaji!
Congratulations on completing the challenge. You did awesome! Your HTML structure is well-organized and demonstrates a solid understanding of semantic elements. However, here are some recommendations and comments in terms of web development best practices: Semantic HTML:
Consider using more semantic elements, such as <article> for the main recipe content and <section> for different sections (like ingredients, instructions, etc.). This improves accessibility and readability. Image Alt Text:
The alt attribute for the image is currently set to "pic." Providing a more descriptive alt text (e.g., alt="Simple Omelette" or alt="Omelette with various fillings") would enhance accessibility for screen readers. Headings Hierarchy:
Ensure that your headings follow a logical hierarchy. For example, use <h2> for "Ingredients" and "Instructions" instead of <h1>, as they are subsections of the main title. Nutrition Information:
You might consider using a table for presenting the nutrition information, which is more structured and easier to read. For example: html Copy code
<table> <tr> <th>Nutrient</th> <th>Value</th> </tr> <tr> <td>Calories</td> <td>277kcal</td> </tr> ... </table> Consistent Class Naming:Ensure that class names are consistently applied and follow a naming convention. For example, you have list and second-list—consider whether these could be unified under a more descriptive name. Responsive Design:
Ensure that your CSS files (styles.css and responsive.css) are optimized for responsiveness. Check that the layout works well on different screen sizes. Multiple Font Preconnects:
You have multiple <link rel="preconnect"> tags for the same URLs. You only need one for each unique origin, so you can remove duplicates. Styling Enhancements:
If your styles.css or responsive.css handles button styles or interactive elements, ensure that they are styled for better user interaction (hover effects, etc.). Unclosed Tags:
There’s a stray period (.) at the end of your last <link> tag. Ensure that it’s removed to avoid HTML errors. HTML Validation:
Run your HTML through a validator like the W3C Validator to catch any potential issues or improvements. Overall, your code is quite good, and these suggestions can help improve accessibility, structure, and readability!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord