@Zukizuk
Posted
Hello there, Congratulations on completing this project
Your solution looks nice
I have few suggestions that I think might be of interest to you.
Consider using <a href="#"></a>
tag for the links instead of <button class="link"></button>
. They are links and since there is a tag for links in html why don't we just use it ? I assure you that using links instead of button is a better option and also helps with accessibilities.
You can even use something like this
<ul>
<li><a href="github.com">Github</a>
</ul>
for this solution and you can style the li as a button and the link will be in perfectly. Consider using this approach now and in your future project
I hope this feedback is helpful
Other than that great job
@mr-vijaychauhan
Posted
@Zukizuk thanks for your suggestion. Later I will try a tag instead of button
@Zukizuk
Posted
@mr-vijaychauhan sure, I am glad my feedback was helpful : )