Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Jessica Randall | Social Links Profile

@mr-vijaychauhan

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Marzuk Sanni 1,360

@Zukizuk

Posted

Hello there, Congratulations on completing this project

Your solution looks nice

I have few suggestions that I think might be of interest to you.

Consider using <a href="#"></a> tag for the links instead of <button class="link"></button>. They are links and since there is a tag for links in html why don't we just use it ? I assure you that using links instead of button is a better option and also helps with accessibilities.

You can even use something like this

<ul>
     <li><a href="github.com">Github</a>
</ul>

for this solution and you can style the li as a button and the link will be in perfectly. Consider using this approach now and in your future project

I hope this feedback is helpful

Other than that great job

0

@mr-vijaychauhan

Posted

@Zukizuk thanks for your suggestion. Later I will try a tag instead of button

0
Marzuk Sanni 1,360

@Zukizuk

Posted

@mr-vijaychauhan sure, I am glad my feedback was helpful : )

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord