Submitted 7 months ago
Responsive IP Address Tracker using React Typescript Tailwind
@kamnida1992
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of understanding how to use API ,and how it works
Community feedback
- @alex931dPosted 7 months ago
Hello great solution but i notice some mistakes, Noting major👍🏻
- Instead of directly fetching in your compunet you should make an universal solution this can be achived in various ways in react for example you can make use of the context react hook to make an global context where you fetch your data another thing i notice was your lack of error handling especially with your fetch method if your http get request fails there is no way your showing the user that it failed other then that instead of fetching when the page is loaded you should fetch before the page is loaded this way ur get request will be loaded faster! And i also notice your poor lack of react.FC this method is depricated and you should not use it also it would be nice if you load your type/interfaces in from a file
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord