Account Deleted
Hello Pogen, good work here, I just would like to suggest the following. When manipulating the DOM is a best practice do not set all the styles values directly by assignment operator. In small projects you can keep track, but the bigger the projects it gets the more complicated will be to keep separated JS and CSS.
Instead of this: document.getElementById("sideNav").style.width = "60%";
Use this: document.getElementById("sideNav").classList.add("someClass")
In your CSS this class should look like this someClass
:
.someClass {
width: 60%;
}
Also I would like to point to the Frontend Mentor report that is generated after you submit the challenge. There are good hints related to HTML structure and Accessibility.
Hope this is useful and happy coding!
Marked as helpful
@IPogenI
Posted
@alexcumplido Thank you so much for the feedback! I will surely keep in mind your tip the next time I do DOM manipulation. Also thanks for pointing out the accessibility errors that i got.
Account Deleted
Great Pogen, you’re more than welcome, happy coding and see you around : )