Elias Lind• 130
@EL132
Posted
Hey David!
Awesome solution that is extremely well done even to the small details! A few small things that will be helpful in the long run:
- When naming classes in CSS, the typical naming conventions is with a hyphen in between the two words in place of a space. I know it may seem like a small thing, but staying uniform across all CSS code helps improve the readability of your code. Instead of your names using _ as the space, consider changing the _ to a - For example: "class="nav__link"" would become "class = "nav-link""
- For your JavaScript code, try to remove excess spacing in between lines of code within your if statements. Also, typical style guides typically have a space after a closing parentheses and an opening curly brace. For example: "if(window.innerWidth < 768){" would become "if (window.innerWidth < 768) {" Overall, this improves readability.
I hope this helps! If it does, please let me know to help my commenting improve! Elias
Marked as helpful
0
P
David Rodriguez B.• 430
@davidFreelance19
Posted
@EL132 Hi Elias! I really appreciate you taking the time to review my code! Still, it's great feedback and I thank you for giving it to me.
Regarding the points about classes, in this specific project I am using a methodology known as BEM, the observation you give me is oriented towards a methodology known as Utilities. And believe me that your comment has helped me, we are in contact to be able to support each other from time to time, take care of yourself!
0
