Responsive Intro Page using HTML, CSS, Bootstrap 4 and a little JS

Community feedback

• 

  NotBenjamin•70

  @AeteungPosted over 2 years ago

  Wow, it is such great work. I think this is by far the nicest solution I have ever seen for this challenge(besides mine xD). I just have a few suggestions for the design part:

  • It would be better for u to set a max-width for the navbar as there might be some monitors with a size of 3440 x 1440. This makes the navbar just too wide for them.
  • Setting the font size for the h1 tag width vw unit is a smart way to do it but it will face the aforementioned problem when the width of the viewport is just too wide.
  • The navbar hover effect is a bit unaesthetic for me as the padding-bottom is larger than the padding-top. If u are trying to give more spacing between li tags, I would suggest u use margin-bottom instead of padding-bottom.
  • Your side nav li tags missed some hover effect.
  • All the SVGs, which are used without handling its viewbox, make their size different and hard to align.

  But overall it is so good, especially that clean js, love it. Well done. OuOb

  Marked as helpful

  0

  ---

  

  Basma Abd Elzaher•50

  @BasmaabdelzaherPosted over 2 years ago

  @Aeteung Ooh .. I can't believe you took all this time and effort to write such a valuable feedback! Thank you so much for this, Really Appreciated!

  Your points are true and legit and now I feel like I should make some changes :D

  Btw, I checked your solution for this challenge and I think it's great too. Thank you again and hope we meet in another challenges :v

  1