Design comparison
Solution retrospective
+1 project complete! Any feedback/tip will be appreciated, thanks!
Community feedback
- @Bishalsnghd07Posted 8 months ago
Hi, @CairoGarb ๐
Your page semantically looking very good, amazing work. You did great job. I like it๐. Just one thing I would recommend, you just add extra thing that is
max-width
in body, which is not needed. It will prevent whole screen actual(Full) width. Let, it be the browser do default behaviour, no need of use unnecessary stuffs. If you see your browser behaviour carefully, it is by default responsive almost. Sometime we add extra things in our browser and breaks the normal flow of our browser. You are giving directly max-width in body(parent) means alternatively you are giving max-width to your all child component. To maintain code quality and code scalability, I would recommend to use max-width in the specific child elements, where it needed not in all.Hope, this small tip will help you!
Congrats for completing this challenge and great job๐
This was my first JS project, I choose to. I enjoy it a lot. This project will practically enhance your basic JavaScript skills.
Happy Codingโค๏ธ
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord