Design comparison
Community feedback
- @Sdann26Posted over 2 years ago
Hi Yemi!
I don't quite understand your idea of giving margin to the card if you are going to position it in the middle, you would have been better off with
top: 50%
and no margin for mobile devices as well as desktop and tablet.Although I don't recommend personally to have used positioning, I understand that your idea is that the rating card comes out as a modal type at the time of clicking on something.
By the way remove the attribute
charset='utf-8'
from the script, it is currently obsolete and will not serve you for anything and will generate an error in the report, remove it so you have 0 errors in your frontend mentor report, do not forget to generate a new one.Good Coding!
Marked as helpful0@YemihunterPosted over 2 years ago@Sdann26 thanks for the feedback. what would you have recommended asides positioning?
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord