バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Styling needs to updated to better match the FEM design.
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
mainelement.
More Info:📚
- The proper way to build this challenge is to create a
formand inside of it, the “rating buttons” should be built using aninput radio(wrap all of them inside afieldset), since this will prevent additional buttons from being active at the same time, and it should have alabelelement attached to it for accessibility.
More Info:📚
MDN <fieldset>: The Field Set element
- Currently, users can submit without selecting a rating. To fix this, you can do one of the following:
- Make the “5” rating the default rating.
- Create an error message, telling users they need make a section.
- Disable the button until a selection is made.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
0
VidsHub• 60
@VidsHub
Posted
@vcarames thank you so much! I'll make the changes. It's so helpful when someone looks at the code and lets you know specific things that should be done to make it better. Thank you for reminding me of best practices; I knew them but as a novice forgot to implement them. Thanks a bunch!!
1
