@Bayoumi-dev
Posted
Hey! It looks good!...
My suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main>
<article class="card-background">
//...
</div >
</article>
Page should contain a level-one heading
, Changeh2
toh1
<h1 class="card-heading">How did we do?</h1>
You should always have one h1
per page of the document... in this challenge, you will use h1
just to avoid the accessibility issue
that appears in the challenge report... but don't use h1
on small components <h1>
should represent the main heading for the whole page, and for the best practice use only one <h1>
per page.
All page content should be contained by landmarks
, Contain the attribution with<footer>
.
<footer>
<div class="attribution">
//...
</div>
</footer>
I hope this is useful to you... Keep coding👍
Marked as helpful
@JanWu100
Posted
@Bayoumi-dev Thank You very much :)