Skip to content
Submitted over 2 years ago

Responsive interactive rating component based on CSS flexbox and JS.

Jan Wągrowski•190
@JanWu100
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would appreciate any tips on how to structure project like this to make it ready for commercial use . What I struggle with the most is how structure data which will be loaded after submitting the form. Should I use innerHTML to render new data as much as possible, or maybe prepare whole templates and swap them. I am also wondering what could I improve in terms of accessibility. I would also appreciate tips regarding any critical mistakes I might have committed.

Community feedback

  • Ahmed Bayoumi•6,740
    @Bayoumi-devPosted over 2 years ago

    Hey! It looks good!...

    My suggestions:

    • Document should have one main landmark, Contain the component with <main>.
    <main>
   <article class="card-background">
      //...
   </div >
</article>
    • Page should contain a level-one heading, Change h2 to h1
    <h1 class="card-heading">How did we do?</h1>

    You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

    • All page content should be contained by landmarks, Contain the attribution with <footer>.
    <footer>
   <div class="attribution">
      //...
   </div>
</footer>

    I hope this is useful to you... Keep coding👍

    Marked as helpful
    1
    Jan Wągrowski•190
    @JanWu100Posted over 2 years ago

    @Bayoumi-dev Thank You very much :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord