Design comparison
Community feedback
- @grace-snowPosted over 2 years ago
Hi
This needs to be a form with fieldset and radio inputs, not a load of buttons. It's very important to get the right form structure.
Make sure you check out the warnings in your report. Using a main tag and footer should solve.
If you want this to be more accessible I also suggest using aria-live on a wrapper around the thank you content so that gets announced to screenreaders. The wrapper element needs to be in the dom (not display none) at all times, but the content within it can be hidden until form submit.
Lastly, on mobile this is spilling off the sides of the screen for me. Make sure you test on all screen sizes. There is no need for a media query on this as it's just a card, but the card should only have a max width and be able to shrink narrower if needed on smaller screens. There should not be much margin around it, only a tiny bit to stop it hitting screen edges
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord