Responsive Interactive Main with CSS and Vanilla JS

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • It is best practice to have separate files for HTML and JS files to make it easier to maintain and organize.

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your “ images/illustrations” to fully remove them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • The attribution should be wrapped inside a footer.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0
• 

  Kacey Kniffen•220

  @KaceyXamPosted almost 2 years ago

  The functionality of the form works great, but the buttons are not circular. To fix that I just explicitly gave them a width and height and it worked.

  Personally, I prefer to use classes for CSS only and id's for JavaScript. What I would have done is put an id on the rating button container and then used querySelectorAll for buttons inside like this.

  const ratingBtns = document.querySelector("#rating-btns");
  const rates = ratingBtns.querySelectorAll("button");
  

  Overall though, good job.

  0