Responsive interactive component (- Mobile: 375px - Desktop: 1440px)
Design comparison
Solution retrospective
Looking forward to any comments and would appreciate them. Also, I had hard time working on the js part of the project and I still there are much better ways to get this done.
Community feedback
- @j-tomajinPosted about 2 years ago
hello,
I notice that you don't have any semantic tags on your HTML, a good practice is to use semantic tags such as main section article an so on. And the latest thing I learned in this challenge was, the right way to do the ratings button is to use form with Input Radio inside of it and with label attached each input.
Happy Coding!
0@ikianmPosted about 2 years ago@AsukalDePapa Hello, thanks for your comment, I will do my best to take care of your advices! About the radio section, I spent around an hour to find out how to style radio buttons and attach the label into it but didn't manage to find anything related. Thanks again for taking your time and reviwing my challenge.
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Kian, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that the html document does not have a
main
tag, every html page must contain a main tag, for people who use navigation aids to be able to identify what is the main content of the screen, to solve this problem we can involve all the content with the main tag, since this page is just a component!The rest is great!
I hope it helps... 👍
0@ikianmPosted about 2 years ago@AdrianoEscarabote Hey Adriano, I appreciate your comment and hints, I will go through the main and other sematic tags next time. Have a good one
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord