Design comparison
Solution retrospective
I didn't know what to look for to solve the problem, how are exchanged two different-sized image depending on screen size. I'm proud to have found scrset attribute.
What challenges did you encounter, and how did you overcome them?I used picture element with scrset attribute.
What specific areas of your project would you like help with?nothing
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.
-
Remove the Header Element, it is not needed for this challenge.
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
The only heading in this challenge is the name of the perfume, “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0@Glorit74Posted about 2 years ago@vcarames Thanks for the tips. I haven't worked with a screen reader yet, it never occurred to me that such a thing existed. I'm just a beginner. I will think about it in the future.
0 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord