Responsive QR code using, CSS and HTML

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  hello Bethel👋, congratulations on completing your first FED challenge 🎉

  I have some suggestions you might find useful.

  1 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div class="qr-container"> With <main class="qr-container">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

  SEO

  And user experience (accessibility) for people using assistive technology such as screen readers.

  2 In order to center the card on any screen add this code snippet to body.

  min-height:100vh;
  display:flex;
  align-items: center;
  justify-content: center;
  
  

  Then remove the margin properties from .qr-container

  I hope this helps 🙃.

  Your solution looks great 😉.

  Happy coding ✌️

  0

  ---

  

  Bethel Ochano•20

  @bethel014Posted 10 months ago

  Thank you @rayaatta for feedback.. noted

  0