Design comparison
Solution retrospective
im not sure why the background images are not showing up , ive commited this repository twice via github but the background images does not appear.
i am going attempt this same challenge using css grids.
as always , i welcome you critique.
thank you.
Community feedback
- @grace-snowPosted over 3 years ago
Hi yusuf,
Yep that path needs updating in css 👆 to fix the bg images
I think you should revisit your html before trying to get the solution closer to the design with css.
In particular
- you're misusing the section element. Read up on it. This whole challenge might be one section not the parts within it
- look up how to write good alt text. Eg for a logo it should just say the word in the image / name of product, or if inside a link it should say where the link goes too
- have you forgotten to import something for those social icons?
- social icons should be inside labelled links too (anchor tags)
- see if you can get the alignment of all on the page on desktop more like the design.
- have you put all styles inside media queries here? If you write mobile styles (not in a media query), you only need a min width one for larger screens
I hope all this helps, good luck with it
1@YusufWebDevPosted over 3 years ago@grace-snow
Thank You! i am new to this XD. this is literally my second webpage ive made on my own after some udemy bootcamp. i have alot to learn.
i appreciate the detailed help.
0 - @mesutcifciPosted over 3 years ago
Hi Yusuf.
Background images don't loading because the path is wrong. Change path with this
url("../images/bg-desktop.svg")
and background will show.Also you should remove
overflow:hidden
property from container element.0@YusufWebDevPosted over 3 years ago@mesutcifci Thank you ! i am making a note of this for the next challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord