Responsive Huddle using flexbox

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi there,

  This looks great on my mobile, the only thing that's quite different to the design is the social icons.

  Looking at the html, it looks like you're using background images for those. That's unusual for these things tbh, it's more common to have images in the html if it's content like this, but it's not 'wrong' or anything. Just make sure the links have aria-labels.

  Looking at css, it could be a lot shorter. Because you've used a lot of widths I think and because you've gone desktop first, that's making the css unnecessarily complicated. I wouldn't expect there to be more than one media query for a challenge like this to be honest. I recommend on your next challenge you try mobile first and see if that makes a difference. If you find yourself wanting to add more than 1-2 min-width media queries, that will be a sign to you there's probably a better way to acheive your layout.

  Best of luck with it

  1
• 

  Vinicius Batista•315

  @VbanetyPosted almost 4 years ago

  Thanks for all the tips you gave me Grace, I'll follow it, and start for mobile first in the next challenge. Grateful :D

  0