Design comparison
Solution retrospective
Any advice or recommendations would be greatly appreciated!
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @kpax10, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Its amazing that you’ve customized some interaction, you’ve to pay attention because when you add some
hover effects
you've to think that for the mobile version there's an issue that the elements with hover getstuck
on the active state of the hover until you click on something else. Something you can do to avoid this problem on mobile, the stick hover, is to add a media query saying that you want hover effects only on devices that are nottouch
. So you can use:@media (hover: hover) { {ADD HERE ALL THE CLASSES WITH HOVER EFFECTS TO DISABLE IT ON MOBILE} }
✌️ I hope this helps you and happy coding!
Marked as helpful0 - @VCaramesPosted about 2 years ago
Hey @kpax10, great job on this project!
Some suggestions to improve you code:
-
For your heading, you always start with <h1> heading. Currently you are using an <h2> heading.
-
To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
Sources:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
Happy Coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord