Responsive huddle landing page with single introductory section

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Shameer! 👋

  Well done on this challenge! Your solution looks great! 👍 It's great to know that you were taking some time to write the README. As you said in the README, it takes time to learn about animation. By the way, Josh Comeau has a great article that might help you learn about animation.

  In your CSS, I noticed this selector header .wrapper-logo img which would much be as .wrapper-logo img . I would recommend adding a class to the logo image so that you don't need to keep referencing the parent element to style the element. It's a good practice to keep the CSS specificity as low and flat as possible. High specificity will make your stylesheet hard to maintain.

  The visually hidden h1 should live inside the main element, not on the header. Also, I think it's okay to make the h2 as h1 and remove the sr-only h1.

  That's it! Happy coding! 😁

  Marked as helpful

  0
• 

  Shameer Kamaludeen•440

  @shameerkamaludeenPosted over 2 years ago

  That's really helpful @vanzasetia, thank you, hope the same in the future commit.

  I appreciate your efforts.

  0

  ---

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @shameerkamaludeen You're welcome, Shameer! Glad that you found it helpful! 😊

  0