Design comparison
SolutionDesign
Solution retrospective
Any suggestions about the project I did and improvements would be great for me to know more and enhance my skills! :)
Community feedback
- @vanzasetiaPosted about 2 years ago
Hello, Paul Toledo! 👋
Congratulations on finishing this challenge! 👏
I have a few suggestions for this solution.
- I would recommend giving your website a nice title. Assistive technology frequently announces the title as the first piece of information. This helps people understand which page or view they will begin navigating (reference: Checklist - The A11Y Project).
- The list of items inside the
footer
should be a list of links. So, I would recommend wrapping the text with an anchor tag. 1440px
for the desktop layout is too late. I would recommend adjusting the breakpoint of the media query. The general rule of thumb is to add media queries whenever the layout needs to change or is no longer good.
I hope these suggestions help!
1@PaulawlietPosted about 2 years ago@vanzasetia can I ask regarding the 1440px what do you mean its too late?
0@vanzasetiaPosted about 2 years ago@Paulawliet
It means that you can apply the desktop styling below 1440px width. 🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord