Design comparison
Solution retrospective
One more challenge done but i'm not proud. I didn't find a way to change the color of social icons. I not confortable with the responsive. That's not awful but not perfect. The "hubble" img go out of border when i enlarge the widows.
Still enjoyed it.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Peally! 👋
Regarding the issue of the logo where at
960px
width the logo starts moving up and gets cut off, it happens because of theheight
on thebody
element. I highly recommend removing all theheight
andmin-height
to solve the issue.Also, I would recommend setting the
width
of the logo with eitherpx
orrem
(recommended) becausevw
unit is a relative unit that might cause an issue on some screen sizes (e.g. the logo will become too small on small screen sizes).The register button can't be both the
button
element and the link element at the same time. I would think that it is a link because as a user I would expect it will navigate me to the registration page if it is a real website. Based on Can I Include having abutton
element as the child of the anchor tag is an invalid HTML. It's also not valid according to W3 Markup validator (see the result).I highly suggest using either
px
orrem
for themargin
andpadding
since there are nomax
properties for them, there's no way you can limit how much it can grow and how much it can shrink. So, usepx
orrem
(recommended) formargin
andpadding
.Usually people use
vw
unit when they useclamp()
function for fluidfont-size
. It's best to makerem
as the main unit in your stylesheet.I hope you find this useful!
Marked as helpful0 - @dostonnabotovPosted over 2 years ago
Hi, there! That looks great. I think it would be better to change the color of the icons. Also, the text color looks kinda different, and the sentence 'build the community' should be on the same line. Everything looks cool. Good luck!
0@PeallyzPosted over 2 years ago@dostonnabotov How do i change the color of the icons I was looking for that but i din't find any way to do it.
I 'll correct the sentence thank you
0@vanzasetiaPosted over 2 years ago@Peallyz You can change the icon color by using
fill
property in the CSS.svg path { fill: <value>; }
Make sure that you are using inline SVG otherwise, it won't work. 🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord