Responsive HTML/CSS flex

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @JulienLebron, congratulations on your solution!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  2.Add the box shadow to stylize the card: box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

  3.Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  1

  ---

  

  cesar hernan ruscica•320

  @hernanruscicaPosted about 2 years ago

  @correlucas I forgot the box shadow issue... Hahaha.. I agree!

  1
• 

  cesar hernan ruscica•320

  @hernanruscicaPosted about 2 years ago

  Hi Julien. I was seeing your solution. It hasn't any issues in the report, congrats for that. My thoughts:

  • the visual result it doesn't look equal, first of all for the sizes. It must just because you understand that 375px is the width of the card container, and it is the size of the viewport in the mobile design .
  • you should use relative units.
  • if you are creating an component, the font family hasn't to be in the body.
  • you probably should use custom variables for the colors and fonts. Overall is great, and working, great job! Greetings

  0