Responsive HTML, Grid and SCSS infocard

Community feedback

• 

  CyrusKabir•1,885

  @CyrusKabirPosted about 3 years ago

  hello my dear friend ♥ your stats card it's good and clean at all but here some little problems :

  • try use more semantics elements like <main>,<footer>,<section>,etc.
  • actually it's hard to read texts on your card so change font-sizes a little bit (specially the text bottom of numbers)
  • and in main design the "m"&"k" in numbers are upper case at last it was good and clean wish you good luck and go ahead for more challanges ♥♥♥

  Marked as helpful

  0

  ---

  

  Javier Lopez•145

  @jglopezrePosted about 3 years ago

  @CyrusKabir Hello, I fixed semantics elements, I am working on font size to make card bigger and easy to read. Thanks.

  1
• 

  Juveria Dalvi•1,375

  @Juveria-DalviPosted about 3 years ago

  hey.. the accessibility issue says that you should have wrapped all divs in <main> which is the semantic tag ,except for the div with class attribution that should be wrapper in <footer> tag for more details refer w3school.com

  0

  ---

  

  Javier Lopez•145

  @jglopezrePosted about 3 years ago

  @juuveria I fixed it, Thank.

  0