Responsive HTML, Flex and SCSS order card component

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. Layout in general looks really good.

  Also, I did not get what you meant by your query, can you explain it a bit clearer.

  Some suggestions as well:

  • The alt of the girl image should have been left empty like alt="". Since that img is just a vector-illustration and it is just for decoration, better use alt="" on it. In an image however adds content to the website, then use a descriptive alt value on it.
  • The music-icon should also used alt="" on it. Also, avoid using words that relates eto "graphic" like "icon, image, picture, etc" as a value on the alt attribute. Assistive tech will handle those for you.
  • When using heading tags, make sure you aren't missing a lower level. If you use h4 tag, then make sure that h1, h2, h3 are present.
  • The proceed to payment and cancel order should be using a tag. Since this is not a form a control like button should not be the proper element.

  Aside from those, great work.

  0

  ---

  

  Javier Lopez•145

  @jglopezrePosted about 3 years ago

  @pikamart Hi!, Thank for your feddback, it was really useful. I fixed code. Thank for your time.

  0