Design comparison
Solution retrospective
Good project to keep layout muscles strong. I wouldn't take as much time as I did but I learned a lot about forms and a11y.
What challenges did you encounter, and how did you overcome them?lots of re-writing code after not getting the error messaging right. I could streamline the error handling.
Community feedback
- @khatri2002Posted 6 days ago
Hi! The developed solution looks good! However, there's something that can be improved.
The
Mortgage Amount
input field has amin="1000"
attribute, meaning values less than 1000 shouldn't be allowed. But when a value below 1000 is entered, the form still gets submitted, the results are displayed, and the default HTML error messageValue must be greater than or equal to 1000.
is also shown. This might confuse the user.To fix this, consider adding a custom validation to prevent the result from being displayed for values below 1000, or remove this validation altogether.
A similar issue exists for the other two input fields as well.
Additionally, it's better not to rely on default HTML error messages when you're already handling errors using your own JavaScript. Having multiple types of error messages with different appearances can disrupt the user experience.
The GitHub repository URL provided seems to be incorrect. Please update it!.
Great work so far! Happy Coding! π
Marked as helpful0 - @MarziaJaliliPosted 9 days ago
Yoooo!!!!!!
Well done, manπ.
This is how you can centerize the
contanier
π€:- Assuming that the
container
is the only child element of thebody
element, you can apply these styles to the body selector to get the job doneπ:
display: grid; place-items: center; min-height: 100vh;
Hope it was SOMETHING, manπππ.
Marked as helpful0 - Assuming that the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord