responsive grid testimonial

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Having empty divs is considered bad practice. to apply the profile images you want tot use the Image Element. Not only that, but the images are not decorative, they add value. The background is to be used for decorative content, like the quote icon in the purple box.

  • Once the profile images are fix, give them an Alt Tag. It should state the following; “Headshot of -person’s full name-“

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”

  • The Section Elements you used to wrap the card would not be the best option. Instead you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  • Adjust the padding and font-size of the components as the screen size decrease to better accommodate the smaller screen size.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  1

  ---

  

  Adam M•550

  @AdamMzkrPosted about 2 years ago

  Thanks a loot @vcarames of your fitback but how to rounded image tag? I try it and its not working that i changed to div :P

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @AdamMzkr

  give all the images the same class, for example, "profile-image" and the CSS property border-radius to that class (start with a value of 30px and adjust to make it a perfect circle).

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @AdamMzkr, congratulations on your new solution!

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Adam M•550

  @AdamMzkrPosted about 2 years ago

  Thanks but I used some of semantic tags like main footer section. But I meet to put more focus on this next Time

  0