Design comparison
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Muhammad Zohaib, congratulations for your new solution!
Your solution seems great, its really nice that you've applied the mobile first approach. There's some stuff to fix in the desktop version, you can start fixing that using
max-width: 1115px
thats the exact container size for this section. Improve thehtml markup
it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with<main>
or section, about the cards you can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.π I hope this helps you and happy coding!
Marked as helpful1@codefolkPosted about 2 years ago@correlucas Much Appreciated. I'll keep in mind all the suggestions you mentioned.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord