@SzymonRojek
Posted
Hi Samyr,
View code button is not referencing to the GitHub files (maybe there is a general problem with it today). There is another way to arrange the blocks differently - column on mobiles, then two rows with two boxes (for tablets) and final design version on desktop, what do you think about it? Also, try to fix the HTML issues report above.
Greetings :D
@SamyrOR
Posted
Hi @SzymonRojek!
Yes, the view code unfortunelly was not working by my fault, now its fixed. And the two rows for tablets is a nice idea! Thank you!
About the HTML issues report is because the excessive h1's i add, now i know to avoid that!
@SzymonRojek
Posted
@SamyrOR
Generally, this project we can treat as a separate page. As you can see at the top you have got header - I would do h1 with two spans because these two sentences are related to each other:
<h1 class="heading-primary">
<span class="heading-primary-main">Reliable, efficient delivery</span>
<span class="heading-primary-sub">Powered by Technology</span>
</h1>
- and underneath I would give a p tag.
What do you think about that?
@SamyrOR
Posted
Thanks @SzymonRojek ! Is an amazing idea, with certain i will code like this now! And, the other titles in the page, like the cards title, is better use h3 right?
@SzymonRojek
Posted
@SamyrOR
I am thinking about it, for me, it is always tricky which one can become a heading from h2-h3 (has to be gradual). I think if you have h1 with the main and subheading then each card can get h2 but if you will give h3 should be ok too. Also, you have got icons but these are only a decorative so the alt text should be empty.
@SamyrOR
Posted
Ooh, ok @SzymonRojek!
You guys helped me a lot!
@SzymonRojek
Posted
@SamyrOR
According to our conversation I can recommend this article from the blog CSS-tricks HTML for Subheadings and Headings. Let me know what do you think about it. IMO each article represents unique content
Greetings :D
