@vanzasetia
Posted
Hi, Ben! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉
I recommend making the <h2>Join our community</h2>
as <h1>
instead. Each page must have one <h1>
as a unique identifier of the page.
You should choose either a button element or an anchor tag for the "Sign up" button. You can't have both at the same time.
Keep in mind when you are deciding to use either an anchor tag or a button element, you should know that:
- anchor tags are for navigation
<button>
element is for actions like opening a modal, submitting a form, toggling an element, etc.
It is essential to use the correct elements.
You should use a list element for the content below the "Why Us". You should not use <br>
elements for presentational purposes. In other words, to make text move to the next line. Learn more — <br>: The Line Break element - HTML: HyperText Markup Language | MDN #accessibility_concerns
Never use px
unit for font sizes. Use rem
or em
instead. Relative units such as rem
and em
can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS
You should define your font-size
on the <body>
element instead. Don't change the <html>
font size as it will overwrite the user's font size setting.
I hope this helps. Happy coding! 😄
Marked as helpful
@MrRobotBDR
Posted
@vanzasetia This is great feedback, thank you.
@vanzasetia
Posted
@MrRobotBDR
You are welcome!