Submitted over 1 year ago

Responsive grid practice - single card challenge

Ben• 290

@MrRobotBDR

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Single price grid component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Thanks. First submission. Still learning and would love some feedback.

Community feedback

Vanza Setia• 27,795

@vanzasetia

Posted over 1 year ago

Hi, Ben! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉

I recommend making the <h2>Join our community</h2> as <h1> instead. Each page must have one <h1> as a unique identifier of the page.

You should choose either a button element or an anchor tag for the "Sign up" button. You can't have both at the same time.

Keep in mind when you are deciding to use either an anchor tag or a button element, you should know that:

anchor tags are for navigation
<button> element is for actions like opening a modal, submitting a form, toggling an element, etc.

It is essential to use the correct elements.

You should use a list element for the content below the "Why Us". You should not use <br> elements for presentational purposes. In other words, to make text move to the next line. Learn more — <br>: The Line Break element - HTML: HyperText Markup Language | MDN #accessibility_concerns

Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS

You should define your font-size on the <body> element instead. Don't change the <html> font size as it will overwrite the user's font size setting.

I hope this helps. Happy coding! 😄

Marked as helpful

Ben• 290

@MrRobotBDR

Posted over 1 year ago

@vanzasetia This is great feedback, thank you.

Vanza Setia• 27,795

@vanzasetia

Posted over 1 year ago

@MrRobotBDR

You are welcome!

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which causes lacking of landmark for a webpage

So fix it by replacing the wrapper <section> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

Ben• 290

@MrRobotBDR

Posted over 1 year ago

@0xAbdulKhalid Thanks very much for the feedback, that is really useful.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord