Responsive Grid layout

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.

  • To center you content to your page, add the following to your Body Element:

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  • The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a Paragraph Element.

  • The Article Element is not the best choice for wrapping these testimonials. In order to use the Article Element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  You instead, want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  1
• 

  Modade•100

  @modieeePosted about 2 years ago

  @AdrianoEscarabote and @vcarames thank you for your suggestions. I have implemented some of them in my code and @vcarames i tried using the

  <figure> <figcaption></figcaption> <blockquotes></blockquotes> </figure> tags on a remake of the same project but it kept adding a huge amount of additional space and got me confused for a long time, I had to turn of all margins and padding before i could detect the problem, I'll like more info on how to properly use it going forward, as i was unable to use it this time.

  0
• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi Modade, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  I noticed that the content is growing a lot at higher resolutions, to fix this we can use a max-width:

  .grid_layout {
      max-width: 1440px;
  }
  

  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  Example:

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  The rest is great!

  I hope it helps... 👍

  0