Responsive Grid layout based Qr-Code component
Design comparison
Solution retrospective
It was very easy for me and I built this without any difficulty. One issue I faced was that I forgot to link the stylesheet with the HTML
Community feedback
- @NehalSahu8055Posted about 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
and headings should always be in sequential order -
<h1>Improve you frontend skills by building projects</h1>
-
Use
Semantics
for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
- Using
<picture>
element is irrelevant here
I hope you find this helpful.
Happy coding😄
Marked as helpful1@Pradyumna-HegdePosted about 1 year agoI took your suggestion very seriously @NehalSahu8055, I am going to refactor it with the necessary changes and requirements. Thanks for your suggestion.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord