Responsive Github Username Finder

Community feedback

• 

  BrunoMoleta•700

  @brunomoletaPosted over 1 year ago

  Hello Daniel, the no results is only being rendered the first time the API does not find the GitHub account that the user searched for. I did not track the bug, but I believe you have to render it when the Fetch returns response.status ===404.

  And I suggest you separate your functions and split your css file into components so it's easier to read and debug.

  It's also on VanillaJS alone, so you will be able to understand it.

  It might be better to use a required inside the input instead of rendering You must enter at least one word!. It's a bit less harsh.

  And cool effect you put on the No results, congrats on that :)

  Marked as helpful

  1
• 

  Adel•820

  @Adel-HarratPosted over 1 year ago

  Congratulation on completing this challenge

  I felt happy when I saw my Github profile 😍

  UI bug: the content is not centered vertically (like theres so much margin-top and 0 margin-bottom)

  Other than that, great job 👌♥

  Marked as helpful

  1

  ---

  

  Daniel•170

  @kadan-developPosted over 1 year ago

  @Adel-Harrat

  Thanks @Adel-Harrat for feedback, appreciate it :) Will check that bug ✌️.

  1