Matt West• 440
@matt-o-west
Posted
Hello! Your layout is very nice, and the page looks responsive on all devices, which is great! A couple issues that I see:
- Your input field is getting cut off on desktop (it's running short of the wrapper)
- I can see the theme context is built into the project with react dev tools (and the screenshot shows this as well), but the theme toggle isn't working
- Your api call is working, but something looks to be off with your user state (problem is probably in Githubsearch.tsx), as whenever I enter a username, it brings me to the user briefly before reverting back to the octocat user
- The search icon should probably have 'aria-hidden="true"' on it so the screenreader doesn't read it
Hope this helps!
Marked as helpful
1
Chris• 410
@cbserra
Posted
@matt-o-west appreciate your input! I think I just submitted it prematurely, however, the API was working earlier, so I think I may have broken something while refactoring.
Also, was having issues with sizing the input bar across the 3 display sizes, and allowing room for the error message. Not sure if I need to look into flex-shrink/flex-grow for those elements, or what.
Thanks again!
0
