Submitted over 3 years ago
Responsive Fylo two column landing page using SCSS, Flexbox, and JS
@JacksonJ97
Design comparison
SolutionDesign
Solution retrospective
Any feedback is greatly appreciated!
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Jackson Jude!
It seems like in your JavaScript there's nothing that says
Valid Email
or anything that tell the user that their email is already valid.Anyway, do you know that you can create an email validation without JavaScript? You can check this CSS Tricks site that explain Form Validation with only HTML and CSS and you can check how it's going to work on this project by checking my solution on this challenge.
More feedback:
- For the company logo, you can just mentioned the company name
Fylo
. - For the
bg-curve
, you can set i it as abackground-image
and position it usingbackground-position
- For the social media links, you can just use
aria-label
on everya
tag and just say the social media platform name, likeFacebook
. Since the screen reader already know that it's a link. Same as images, you don't need to typeimage of
orphoto of
. - For the phone number you can use
tel
and for the email you can usemailto
.
That's it! Overall everything looks good on my mobile device! 🙌 Hopefully this is helpful!
Marked as helpful1 - For the company logo, you can just mentioned the company name
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord