Responsive Fylo landing page with two column layout

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Luis! 👋

  It's good to see you completing another challenge! 👏

  Regarding your question about the container element, if you see the site on a wide screen like 1800px, you will notice that the site starts becoming too large. So, I recommend having a max-width to prevent the elements from becoming too large.

  Also, I recommend only limiting the page content instead of the background too, this way the site looks more natural and has no empty space while the footer has full width.

  More feedback.

  • Put the header element outside of the main element. It's not going to have meaning if you put it inside the main element.
  • I suggest removing all the visually hidden headings and making the h2 as h1 instead. sr-only is used only if the site has no visible text like an icon button or in Frontend Mentor challenges circumstances, no visible h1 on the component challenges (assuming that the h1 exist somewhere else on the page). So, my point is that don't use visually hidden element as long as there's visible text.
  • input with type="submit" was used before the button element exist. It's best to avoid using legacy elements. So, I recommend using button element instead.
  • The secondary navigation on the footer should be wrapped by nav element. Add an aria-label to both nav elements so that screen reader users can distinguish the two navigation elements. So, the nav on the header would be the primary navigation, so the value for the aria-label would be primary and for the other one would secondary.
  • Good job on labeling the social media links! 👍

  That's it! Happy coding!

  Marked as helpful

  1

  ---

  

  Luis paz•390

  @PazispeacePosted over 2 years ago

  @vanzasetia Thank you!!, I have done what you told me. I will try to not forget about those details next time.

  Thank you so much for taking the time to help the community!!

  have a nice day! happy codding to you too

  Edit:

  I forgot to change the input to button for submit. Already done.

  And yeah! I was aware of the button, somehow I forgot about it when making the form, thank you so much!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Pazispeace You're welcome! 😄

  Amazing! Great job with the updates! 👍

  Keep up the great work!

  1