Design comparison
Solution retrospective
Hey guys! any feedback is acceptable because there may be something that I missed but is visible for u guys so let me have your comment and have an update...I will be thankful for your feedbacks ...so please drop your comment here...
Community feedback
- Account deleted
Hi there! Congrats on completing this challenge!! š„³š„³š
Here some tips to improve your solution. šÆ
HTML: š§±
Your main content should be contained within the
main
tag. and so put all the sections inside it.Your forms should be inside the
form
tag, not thediv
tag. and it's not thea
tag it's thebutton
orinput:submit
tag.You cannot use the
h1
tag more than once. You must remember that it is only used once, and continue successively withh2, h3, h4, h5, h6
, and not skip header levels.Social media links have no text available. You can add the
aria-label='your text'
attribute to fix that problem.Change the
div
tag with theheader-link
class to thenav
tag.I suggest you do some research on HTML5.
CSS: šØ
Your reset is good, but you can improve it by using some popular resets like the following š:
I hope I've helped you
Happy coding! āļø
Marked as helpful1@proabrePosted over 1 year ago@FLCHRIS thanks a lot man .... your feedback is goanna help me a lot thanks again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord