Design comparison
Solution retrospective
Hi everyone,
this challenge tested my positioning skills a little. If you have any tips for more efficient code, please leave a comment.
Thank you
Klara
Community feedback
- @M-lakshanPosted about 2 years ago
Hello Klara,
I also did this recently. There are few things u need to focus on. If we consider such a web page (like an actual cloud platform or content share page) those
<img src="*****.svg">
beside thelogo <img>
should be eitherbutton elements
orlink elements
because they should perform an action in that area.Next time try giving a static position for a background image by
background-position: 0% bottom;
. This way the image always stays bottom according to theview height
. If you give only the dynamic percentage value, the image will move away from the alignments when the screen size change.Other than that, I like the way u kept the CSS code as simple as possible. So good luck then, Happy coding! 🙂
Marked as helpful0@klara367Posted about 2 years agoHi Lakshan,
thank you for your feedback. You are right with those links. I don't know why I missed that in the first place.
And about that background, I had it
background-position: bottom
in the beginning, but it was higher than given design so I moved it. But I see it's not a great solution for responsibility.0@M-lakshanPosted about 2 years ago@klara367 use an emulated window like in Chrome or Firefox dev tools & see... u can get the idea when the window size changes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord