@michel-moreira
Posted
Hello Nicholas!
Great job on complete this challenge!
I have some suggestions tha might be helpful!
-
In the img tag, you must put an alternate text, the attribute "alt". The required alt attribute provides an alternate text for an image, if the user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader). Source.
-
You must put a h1 tag on the pag cause the page should contain a level-one heading, you could replace the p tag and just maintain the class the same, so your code remains unchanged.
-
All your principal code should be wrapped by
main
tag landmark, between the tags main and div attribution you've putted asection
tag to treat the second element. Would be better if you use 2 sections inside the main instead on main and a section out of the main. One section to the first element and other section to the second one. Themain
tag is more like a container and not an element itself. -
Inside the tag
section
you could use ah1
heading level rather thanp
. And the div 'amount-left' you could useh2
as well. -
Your div attribution could be replaced by the
footer
tag to be more semantic.
I hope you find it helpful!
Happy Coding!
@nicoams
Posted
@michel-moreira Hi there.
The main
tag is wrapping all the content. The first element contains the logo and links so I used a header
to wrap it (I think it works as a header, just in another position other than on top haha) and a section
to wrap the "content".
I made others changes as you suggested.
Thank you for the feeback.