Submitted almost 4 years ago
Responsive fylo dark theme landing page using Grid Flexbox Sass
@dacitto
Design comparison
SolutionDesign
Solution retrospective
Hello There 👋👋 , Hope you give me your helpful feedback ✍️✍️✍️. What's your rating for responsiveness? Thank you 💖💖
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hey there, Salah Eddine! 👋
It's nice to see you complete another challenge! 😀 Great work on this challenge! 🙌 Your solution looks good and everything responds quite well! 👍
I'd like to suggest,
- Turning the navigation links in the footer of the page into actual links using the anchor tag.
- This is a minor thing, but I think adding a max-width to the items in the features section and the testimonial cards (and then horizontally centering them) would be a good idea so that those elements are too wide when the layout of the page first changes from desktop to mobile. 😉
- Adding a label to the email input element to make your solution more accessible.
- Using only one
<h1>
tag per page (and using less important heading tags for anything besides the main heading).
Keep coding (and happy coding, too)! 😁
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord