Alexandra• 510
@Alexandra2888
Posted
Hi! Congrats for finishing challenge! Your solution looks very close to the design. Things I think you can improve:
-in HTML: you can use section for every wrap component. it's better to use more semantic tags, it's also improving readability than using a lot of divs. For div class="attributes" I suggest using footer tag. You can use svg in many ways, see a detailed article from FreeCodeCamp here: https://www.freecodecamp.org/news/use-svg-images-in-css-html/
-in SCSS: you can use *::after and *::before to target also pseudo-elements. Also implementing BEM naming convention in your classes would allow you to nest scss classes and improve your code readability. Happy coding!
Marked as helpful
0
