Responsive, Fully completed challenge

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Good work, almost close to design.

  • use HTML5 tags like section article, main after body

  Marked as helpful

  2

  ---

  

  Moek UgD•40

  @m0ekugdPosted about 3 years ago

  @afrussel Thanks for help, I did not know these tags.

  0
• 

  darryncodes•6,390

  @darryncodesPosted about 3 years ago

  Awesome work Moek, really well done!

  Some thoughts i had:

  • you could clear up your accessibility report by making this <div class="main"> a <main> tag. And consider using an <h1>
  • also your design doesn't quite like the 320px width. It might break on an iPhone 5/SE

  Happy coding 🤙

  Marked as helpful

  1

  ---

  

  Moek UgD•40

  @m0ekugdPosted about 3 years ago

  @darryncodes Hello thanks for helping I didn’t know about main tag. Also i made the main div design only responsive because I forgot to make responsive for other elements too. I will try to fix it within a few days in free time. Thanks

  0