Responsive Frontend Work With SCSS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • to fix this issue raised in the report Document should have one main landmark , you need to have a main element in your html. You can try to use the main as a container for the section's elements , such that you have a header, main, footer
  • some of the nav items are best presented as list items , hence the need to have an unordered list for accessibility.
  • the btnHamburger is supposed to be a button since its main purpose is to open and close the navigation list, an anchor element should be used for links that open other pages
  • heading elements must ascend in order without skipping headings (h1, h2, h3 etc)
  • read about responsive images techniques , mainly srcset and picture element, the method below is not considered as best practice.

   <div class="sec_2_hero_img">
        <img class="hide-for-desktop" src="/images/illustration-phones.svg" alt="">
        <img class="hide-for-mobile" src="/images/illustration-phones.svg" alt="">
      </div>
  

  • there is still some few work to be done to make it responsive, on mobile content is not fitting on the screen.

  Happy coding

  0