Responsive four-card-feature page, Mobile first, css grid & flexbox

Community feedback

• 

  argel omnes•1,800

  @argelomnesPosted about 5 years ago

  Hi Zeek,

  This is pretty neat! Though I find your use of br creative, I think giving your article a bottom margin will give you more flexibility.

  2

  ---

  

  Zeek•430

  @odkpatrickPosted about 5 years ago

  Thanks for the tip @argelomnes.

  Ironically, I did use a bottom margin initially, but then decided to use the br tag for some reason.

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Great work on this challenge Zeek, your solution looks great! 👍

  I would recommend only using article elements to wrap self-contained content that could live on its own without anyone knowing the wider context of the site. Examples would be blog posts, articles and forum posts. Here's a link to MDN for more details. In this instance, I would have the .cards-container as a section and then each of the cards as div elements.

  Let me know if you have any questions!

  0

  ---

  

  Zeek•430

  @odkpatrickPosted about 5 years ago

  @mattstuddert Thank you for the feedback and link.

  I've updated the repo and I'll keep working on better semantic use.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @odkpatrick you're welcome! 👍

  0