@haquanq
Posted
Hello @kristinakasalova 👋
Here is my feedback on how you can improve your solution:
- About keeping card titles within borders, you need to make the text break when meeting the border by specifying
word-break: break-word
as the only element overflowing the card is the paragraph. - You should also consider using
display: grid
instead ofdisplay: flex
to manipulate a grid of items, it is much more robust and convenient. - Consider using more semantic markups instead of
div
(avoid usingdiv
when ever possible, i will explain later) such assection, article, figure,...
.For example, you can choosesection or article
to wrap the card (depend on what context you want to provide - is it a section or article?).
If you want, you can check out my solution for this challenge for more references.
Have a nice day and happy coding! 🕺🕺🕺🕺🕺🕺🕺