Submitted almost 2 years ago
Responsive Four Card Section using Grid Flexbox
@whiteknight-dev
Design comparison
SolutionDesign
Solution retrospective
Any help to improve is welcome, thank you =).
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
article
element is being used incorrectly ⚠️ and not needed for this challenge .
- The intro heading and paragraph ⚠️ should be wrapped inside a
header
element.
- Avoid skipping heading levels ⚠️. Always start with the
h1
(which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.
- The “Reliable, efficient delivery Powered by Technology” is one single heading ⚠️ so the entire thing should be wrapped in a single
h1
heading and either the top/bottom text will have aspan
element.
- The
main
element should only ⚠️ be wrapping the card section since that is the main content of your page.
- Using
CSS Grid
withGrid-Template-Areas
will make things way easier 💯 when building the layout; it will give you full control of the layout.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0@whiteknight-devPosted almost 2 years ago@vcarames Thanks, I've already made the corrections, it helps me a lot to improve my code skills, I appreciate it 😄.
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord