Design comparison
Solution retrospective
Took me forever to figure out how to adjust the first and third row along the center axis properly. Happy I finally did the readme. Time to update everything I've ever posted on Github.
What challenges did you encounter, and how did you overcome them?I was very close to giving up because of the section alignment. I guess you can't do it without flex.
What specific areas of your project would you like help with?I want to minimize the use of media queries if I can. Even though the larger and mobile screen sizes work I'd like to get better at the in-between. As you make the window smaller, I'd like for the sections to adjust better. Please advise.
Community feedback
- @KapteynUniversePosted about 9 hours ago
Hey Abigail,
You can do it with flex. Just wrap team builder and karma with a div, apply flex to the main and change flex-direction with a media query.
For the media queries, i think it is possible to do this challenge without any media query with using grid, i recently changed my solution from flex to grid. I was so close to do it without a media query
There are other issues to be addressed tho:
I think you can remove contentWrapper div and apply padding to the body.
I think you mixed up header with heading
margin: 1rem 31rem 0 31rem;
on h3 is too much. You can usemax-width: 60ch;
to get around the same width, ormax-width: 30rem;
andmargin-inline: auto;
to make it centered. Look here for the css unitsYou can add flex or grid to body so header and main will be centered too, no need all of that big margings
body { display: flex; flex-direction: column; justify-content: center; align-items: center; }
Remove marging left and right from the main after this. They are shrinking the main a lot around 900px.
Lastly you don't have to use media query at 376px because design image is 375px. Change the layout whenever you feel is good, you can even add a tablet layout too. So after all of this changes, i think you can change to mobile or desktop at 768px
@media (min-width: 768px)
0 - @mohamed-fmPosted about 17 hours ago
You really did a good job , keep it this way <3
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord